goodboy
/
tractor
1
0
Fork 1
Code Issues 1 Pull Requests 4 Packages Projects Releases Wiki Activity

Don't (noisly) log about runtime cancel RPC tasks 

Since in the case of the `Actor._cancel_task()` related runtime eps we
actually don't EVER register them in `Actor._rpc_tasks`.. logging about
them is just needless noise, though maybe we should track them in a diff
table; something like a `._runtime_rpc_tasks`?

Drop the cancel-request-for-stale-RPC-task (`KeyError` case in
`Actor._cancel_task()`) log-emit level in to `.runtime()`; it's
generally not useful info other then for granular race condition eval
when hacking the runtime.
runtime_to_msgspec
Tyler Goodlet 2024-05-28 16:03:36 -04:00
parent a1b124b62b
commit 2db03444f7
2 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tractor/_rpc.py
View File

@ -397,12 +397,18 @@ async def _errors_relayed_via_ipc(
f'|_{ctx._task}\n' f'|_{ctx._task}\n'
f' >> {ctx.repr_rpc}\n' f' >> {ctx.repr_rpc}\n'
) )
else: # TODO: remove this right? rn the only non-`is_rpc` cases
log.cancel( # are cancellation methods and according the RPC loop eps
'Failed to de-alloc internal runtime cancel task?\n' # for thoses below, nothing is ever registered in
f'|_{ctx._task}\n' # `Actor._rpc_tasks` for those cases.. but should we?
f' >> {ctx.repr_rpc}\n' #
) # -[ ] maybe we should have an equiv `Actor._runtime_rpc_tasks`?
# else:
# log.cancel(
# 'Failed to de-alloc internal runtime cancel task?\n'
# f'|_{ctx._task}\n'
# f' >> {ctx.repr_rpc}\n'
# )
finally: finally:
if not actor._rpc_tasks: if not actor._rpc_tasks:

7
tractor/_runtime.py
View File

@ -1256,9 +1256,10 @@ class Actor:
# - child returns a result before cancel-msg/ctxc-raised # - child returns a result before cancel-msg/ctxc-raised
# - child self raises ctxc before parent send request, # - child self raises ctxc before parent send request,
# - child errors prior to cancel req. # - child errors prior to cancel req.
log.cancel( log.runtime(
'Cancel request invalid, RPC task already completed?\n\n' 'Cancel request for invalid RPC task.\n'
f'<= canceller: {requesting_uid}\n\n' 'The task likely already completed or was never started!\n\n'
f'<= canceller: {requesting_uid}\n'
f'=> {cid}@{parent_chan.uid}\n' f'=> {cid}@{parent_chan.uid}\n'
f' |_{parent_chan}\n' f' |_{parent_chan}\n'
) )