tractor/ai/prompt-io/opencode/20260828T014247Z_d06ee34b_p...

---
model: openai/gpt-5.6-sol
service: opencode
session: pr490-landing-review
timestamp: 2026-08-28T01:42:47Z
git_ref: wkt/fix_broadcast_lag_count
scope: code
substantive: true
raw_file: 20260828T014247Z_d06ee34b_prompt_io.raw.md
---

## Prompt

Prime PR #490 for landing, review its concurrent broadcast changes,
fix valid findings, and keep the landing pass focused.

## Response summary

Rejected an invalid mutable-default finding under `msgspec.Struct`
semantics. Found and fixed a close-time race where concurrent receives
on one `BroadcastReceiver` could overwrite its sole cancellation scope
and strand an earlier waiter. The receiver now rejects overlapping
calls with `trio.BusyResourceError`. Public docs now define each
receiver as one logical subscription cursor and require one receiver
per concurrent lossless consumer. Busy errors identify the active Trio
task which owns the receiver.

## Files changed

- `tractor/trionics/_broadcast.py` - reject concurrent receives on one
  receiver handle.
- `tests/test_task_broadcasting.py` - prove the second call fails while
  the original receive remains usable.
- `docs/guide/streaming.rst` - document per-task receiver ownership and
  explicit lag behavior.

## Human edits

The human selected PR #490 as the next landing target, rebased it onto
current `main`, directed the agent to continue the landing pass, and
required a faster, tightly scoped execution after the review expanded.
The human then confirmed the per-receiver guard and required the public
method, type, and surrounding guide to emphasize lossless per-consumer
semantics. The human also required the regression's checkpoint loop to
explain its synchronization and the busy error to report the active
consumer task. The agent applied the source, test, and documentation
changes; no direct manual edits to these files were identified.
Reject concurrent `BroadcastReceiver.receive()` calls Two tasks could receive through one `BroadcastReceiver` and race its single `_wait_scope`. A later call could replace the scope, leaving the first blocked through `.aclose()`. Track the active `trio.lowlevel.Task` per receiver and reject an overlapping call with `trio.BusyResourceError`. Include the owner's task name and repr in the error, then clear ownership in `finally`. Define each receiver as one logical subscription cursor. Concurrent consumers must use separate `.subscribe()` receivers so each retains an independent cursor and lag policy. Strict mode reads every retained value or raises `Lagged`; `raise_on_lag=False` explicitly permits drops. Cover the regression with a checkpoint loop synchronized on `recv_ready`; explain the interleaving inline, assert the error names the active consumer, then release the source and prove the original receive remains usable. Prompt-IO: ai/prompt-io/opencode/20260828T014247Z_d06ee34b_prompt_io.md (this patch was generated in some part by `opencode` using `gpt-5.6-sol` (`openai`)) 2026-08-28 02:11:55 +00:00			`---`
			`model: openai/gpt-5.6-sol`
			`service: opencode`
			`session: pr490-landing-review`
			`timestamp: 2026-08-28T01:42:47Z`
			`git_ref: wkt/fix_broadcast_lag_count`
			`scope: code`
			`substantive: true`
			`raw_file: 20260828T014247Z_d06ee34b_prompt_io.raw.md`
			`---`

			`## Prompt`

			`Prime PR #490 for landing, review its concurrent broadcast changes,`
			`fix valid findings, and keep the landing pass focused.`

			`## Response summary`

			Rejected an invalid mutable-default finding under `msgspec.Struct`
			`semantics. Found and fixed a close-time race where concurrent receives`
			on one `BroadcastReceiver` could overwrite its sole cancellation scope
			`and strand an earlier waiter. The receiver now rejects overlapping`
			calls with `trio.BusyResourceError`. Public docs now define each
			`receiver as one logical subscription cursor and require one receiver`
			`per concurrent lossless consumer. Busy errors identify the active Trio`
			`task which owns the receiver.`

			`## Files changed`

			- `tractor/trionics/_broadcast.py` - reject concurrent receives on one
			`receiver handle.`
			- `tests/test_task_broadcasting.py` - prove the second call fails while
			`the original receive remains usable.`
			- `docs/guide/streaming.rst` - document per-task receiver ownership and
			`explicit lag behavior.`

			`## Human edits`

			`The human selected PR #490 as the next landing target, rebased it onto`
			current `main`, directed the agent to continue the landing pass, and
			`required a faster, tightly scoped execution after the review expanded.`
			`The human then confirmed the per-receiver guard and required the public`
			`method, type, and surrounding guide to emphasize lossless per-consumer`
			`semantics. The human also required the regression's checkpoint loop to`
			`explain its synchronization and the busy error to report the active`
			`consumer task. The agent applied the source, test, and documentation`
			`changes; no direct manual edits to these files were identified.`