46 lines
1.5 KiB
Markdown
46 lines
1.5 KiB
Markdown
|
---
|
||
|
|
model: openai/gpt-5.6-sol
|
||
|
|
service: opencode
|
||
|
|
timestamp: 2026-08-17T23:18:25Z
|
||
|
|
git_ref: 359fe75c
|
||
|
|
diff_cmd: git diff HEAD~1..HEAD
|
||
|
|
---
|
||
|
|
|
||
|
|
Applied the seven accepted manual-review fixes for PR #475 while
|
||
|
|
preserving the Windows transport capability behavior.
|
||
|
|
|
||
|
|
> `git diff HEAD~1..HEAD -- tractor/ipc/_types.py`
|
||
|
|
|
||
|
|
The generated changes restore the project's single-quote docstring and
|
||
|
|
string conventions, remove the unnecessary helper divider, simplify the
|
||
|
|
transport-registry comments, and restore `match/case` socket-family
|
||
|
|
dispatch. The UDS case retains a `HAS_UDS` guard that short-circuits
|
||
|
|
before `socket.AF_UNIX` is evaluated on unsupported hosts. Nearby error
|
||
|
|
messages are wrapped without changing their content.
|
||
|
|
|
||
|
|
> `git diff HEAD~1..HEAD -- tractor/ipc/_uds.py`
|
||
|
|
|
||
|
|
The generated change reformats the `HAS_UDS` conjunction according to
|
||
|
|
the project's multiline boolean-expression convention and simplifies
|
||
|
|
the adjacent capability comment.
|
||
|
|
|
||
|
|
Verification:
|
||
|
|
|
||
|
|
`/home/goodboy/repos/tractor/py313/bin/pytest -q tests/test_lazy_imports.py tests/discovery tests/ipc/test_server.py`
|
||
|
|
|
||
|
|
Result: `66 passed, 2 xpassed in 60.62s`.
|
||
|
|
|
||
|
|
`ruff check --no-cache --output-format=json tractor/ipc/_types.py tractor/ipc/_uds.py`
|
||
|
|
|
||
|
|
Result: no findings.
|
||
|
|
|
||
|
|
`git diff --check`
|
||
|
|
|
||
|
|
Result: no whitespace errors.
|
||
|
|
|
||
|
|
An explicit missing-`AF_UNIX` probe set `HAS_UDS = False`, removed the
|
||
|
|
socket constant, and exercised an unsupported socket family. It raised
|
||
|
|
the expected `NotImplementedError` instead of `AttributeError`.
|
||
|
|
|
||
|
|
No review replies, commits, or pushes were published.
|