39 lines
1.3 KiB
Markdown
39 lines
1.3 KiB
Markdown
|
---
|
||
|
|
model: openai/gpt-5.6-sol
|
||
|
|
service: opencode
|
||
|
|
session: d9d7df2c-7044-463f-8768-ec024718eac9
|
||
|
|
timestamp: 2026-08-25T01:57:42Z
|
||
|
|
git_ref: e42ecb55
|
||
|
|
scope: code
|
||
|
|
substantive: true
|
||
|
|
raw_file: 20260825T015742Z_e42ecb55_prompt_io.raw.md
|
||
|
|
---
|
||
|
|
|
||
|
|
## Prompt
|
||
|
|
|
||
|
|
Continue PR #481 review remediation after committing the `Aid` reap-map
|
||
|
|
migration. The human selected "keep" for comments explaining why both
|
||
|
|
spawn backends provisionally register children with `portal=None`.
|
||
|
|
|
||
|
|
## Response summary
|
||
|
|
|
||
|
|
Document that a child has no `Portal` until its IPC handshake yields a
|
||
|
|
`Channel`, and make `portal=None` explicit at both registration calls.
|
||
|
|
Identify the later replacement of each provisional entry with
|
||
|
|
`Portal(chan)`. Update the MP registration test double to accept and
|
||
|
|
assert the explicit provisional portal state. Name every registration
|
||
|
|
argument consistently in both backends.
|
||
|
|
|
||
|
|
## Files changed
|
||
|
|
|
||
|
|
- `tractor/spawn/_mp.py` - clarify provisional MP registration.
|
||
|
|
- `tractor/spawn/_trio.py` - clarify provisional Trio registration.
|
||
|
|
- `tests/test_to_actor.py` - model explicit provisional registration.
|
||
|
|
|
||
|
|
## Human edits
|
||
|
|
|
||
|
|
The human explicitly selected "keep" after receiving keep/defer/drop
|
||
|
|
options for this paired clarification. During local review, the human
|
||
|
|
then requested that `subactor` and `proc` also be passed by name in both
|
||
|
|
backend calls. No direct source-line edits were made by the human.
|