44 lines
1.5 KiB
Markdown
44 lines
1.5 KiB
Markdown
|
---
|
||
|
|
model: openai/gpt-5.6-sol
|
||
|
|
service: opencode
|
||
|
|
session: pr481-review-fixes-p1-20260818
|
||
|
|
timestamp: 2026-08-18T03:15:32Z
|
||
|
|
git_ref: 4151b956
|
||
|
|
scope: code
|
||
|
|
substantive: true
|
||
|
|
raw_file: 20260818T031532Z_4151b956_prompt_io.raw.md
|
||
|
|
---
|
||
|
|
|
||
|
|
## Prompt
|
||
|
|
|
||
|
|
Address the approved review findings on PR #481, but work
|
||
|
|
iteratively: implement and verify one finding at a time, prepare a
|
||
|
|
separate `/commit-plan` after each fix, and stop for the human commit
|
||
|
|
before starting the next finding. Begin with the P1 per-child
|
||
|
|
lifecycle issue. Also publish the already-approved review findings
|
||
|
|
against the reviewed PR head before editing.
|
||
|
|
|
||
|
|
## Response summary
|
||
|
|
|
||
|
|
Published the approved non-approving review at head `4151b956`, then
|
||
|
|
implemented only the P1 lifecycle fix. Owned one-shot actors now use
|
||
|
|
a child-specific cancellation and process-reap handshake, including
|
||
|
|
hard escalation for unacknowledged cancellation and deterministic
|
||
|
|
bookkeeping removal before `to_actor.run()` returns.
|
||
|
|
|
||
|
|
## Files changed
|
||
|
|
|
||
|
|
- `tractor/runtime/_supervise.py` - coordinate child-specific cancel
|
||
|
|
and reap.
|
||
|
|
- `tractor/spawn/_trio.py` - wait on the Trio child's reap request.
|
||
|
|
- `tractor/spawn/_mp.py` - wait on the multiprocessing child's reap
|
||
|
|
request.
|
||
|
|
- `tractor/spawn/_spawn.py` - publish monitor completion centrally.
|
||
|
|
- `tractor/to_actor/_api.py` - await owned-child process reaping.
|
||
|
|
- `tests/test_to_actor.py` - cover cleanup, escalation, and startup
|
||
|
|
ordering.
|
||
|
|
|
||
|
|
## Human edits
|
||
|
|
|
||
|
|
None - the generated P1 patch remains uncommitted for human review.
|