48 lines
2.1 KiB
Markdown
48 lines
2.1 KiB
Markdown
|
---
|
||
|
|
created_at: 2026-10-20T19:36:19Z
|
||
|
|
generated_by:
|
||
|
|
harness: opencode
|
||
|
|
provider: openai
|
||
|
|
model: openai/gpt-6.1-sol
|
||
|
|
git_ref: 0553fcf8
|
||
|
|
diff_cmd: git diff HEAD~1..HEAD
|
||
|
|
---
|
||
|
|
|
||
|
|
## Generated review adjustments
|
||
|
|
|
||
|
|
> `git diff HEAD~1..HEAD -- tests/test_context_final_return_disconnect.py`
|
||
|
|
|
||
|
|
Added a test-local arbitrary-task formatter and snapshots of the endpoint
|
||
|
|
task and its nursery-owning task before the dispatcher wrapper exits.
|
||
|
|
The collateral-cancellation report includes actor identity, sibling,
|
||
|
|
endpoint and owner task fields, parent cancel-scope state and the original
|
||
|
|
cancellation repr. Added the requested blank line after the request prose.
|
||
|
|
|
||
|
|
> `git diff HEAD~1..HEAD -- tractor/runtime/_rpc.py`
|
||
|
|
|
||
|
|
Replaced ad-hoc warning labels with Actor/Context/Channel pformat output,
|
||
|
|
the existing cancel-scope formatter and a nested transport-error report.
|
||
|
|
The TransportClosed guard still encloses only final-result transmission.
|
||
|
|
|
||
|
|
## Verification output
|
||
|
|
|
||
|
|
Modern downstream evaluation environment (Python 3.13.14, Trio 0.32.0,
|
||
|
|
pytest 9.0.2): regression plus RPC suite, 10 passed in 1.22s.
|
||
|
|
Standalone Ruff: All checks passed! Git whitespace check passed.
|
||
|
|
|
||
|
|
The worktree environment has Python 3.13.13, Trio 0.29.0 and pytest 9.1.0:
|
||
|
|
9 passed, 1 failed because the pre-existing test expects TransportClosed
|
||
|
|
in cancellation provenance, while this older Trio renders only Cancelled.
|
||
|
|
Executing the captured pre-review test in memory reproduced that assertion
|
||
|
|
failure; it was not caused by these review adjustments. No environment or
|
||
|
|
dependency was changed. The modern environment's pytest is below the
|
||
|
|
current harness reference's >=9.0.3 requirement; that limitation remains.
|
||
|
|
|
||
|
|
An in-memory probe removed only the final-send guard and reproduced the
|
||
|
|
expected TransportClosed failure. It verified the enhanced exception note
|
||
|
|
contains the blank separator, actor identity, three structured task
|
||
|
|
reports, task ownership fields and cancellation source. Source files were
|
||
|
|
unchanged by the probe. Initial scratch-probe validation errors were
|
||
|
|
corrected before the successful expected-red checks; they were not
|
||
|
|
repository test regressions.
|