35 lines
1.1 KiB
Markdown
35 lines
1.1 KiB
Markdown
|
---
|
||
|
|
model: openai/gpt-5.6-sol
|
||
|
|
service: opencode
|
||
|
|
session: ses_3e4c90d3eafeqHEtRYSIHgHhpA
|
||
|
|
timestamp: 2026-08-19T02:07:57Z
|
||
|
|
git_ref: b38efed7
|
||
|
|
scope: code
|
||
|
|
substantive: true
|
||
|
|
raw_file: 20260819T020757Z_b38efed7_prompt_io.raw.md
|
||
|
|
---
|
||
|
|
|
||
|
|
## Prompt
|
||
|
|
|
||
|
|
Resolve the remaining P3 review finding before landing PR #481:
|
||
|
|
`runtime_kwargs={}` must not be silently accepted alongside either
|
||
|
|
`an=` or `portal=` merely because the dict is falsey. Keep this as its
|
||
|
|
own final review-remediation commit.
|
||
|
|
|
||
|
|
## Response summary
|
||
|
|
|
||
|
|
Treat any non-`None` `runtime_kwargs` value as provided when validating
|
||
|
|
placement. Cover both placement APIs with empty and configured dicts,
|
||
|
|
proving the error is raised locally before actor startup.
|
||
|
|
|
||
|
|
## Files changed
|
||
|
|
|
||
|
|
- `tractor/to_actor/_api.py` - validate option presence explicitly.
|
||
|
|
- `tests/test_to_actor.py` - cover four invalid option combinations.
|
||
|
|
|
||
|
|
## Human edits
|
||
|
|
|
||
|
|
No direct line edits. The human accepted the P3 finding, required it to
|
||
|
|
remain separate from the five P2 behavioral commits and prioritized it
|
||
|
|
before the final PR #484 integration rebase and PR #481 landing steps.
|